search

cert-manager / approver-policy

approver-policy is a cert-manager approver that allows users to define policies that restrict what certificates can be requested.
https://cert-manager.io/docs/policy/approval/approver-policy/
Apache License 2.0
66 stars 23 forks source link

chore: pre-fix new nilnil linter error #486

Closed erikgb closed 2 months ago

erikgb commented 2 months ago

For https://github.com/cert-manager/approver-policy/pull/485 to go through, we have to do something, since the newer version of golangci-lint adds some additional rules. Instead of just suppressing the lint errors, I suggest making the (unused) stub functions return a "not implemented" error.

/cc @inteon

cert-manager-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/approver-policy/blob/main/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment