search

cert-manager / aws-privateca-issuer

Addon for cert-manager that issues certificates using AWS ACM PCA.
Apache License 2.0
192 stars 81 forks source link

topologySpreadConstraints support in helm chart #245

Closed BryanStenson-okta closed 1 year ago

BryanStenson-okta commented 1 year ago

Describe why this change is needed

It would be nice to have topologySpreadConstraints support in the official helm chart

/kind feature

Describe solutions and alternatives considered (optional)

No response

Is there anything else you would like to add?

No response

jetstack-bot commented 1 year ago

@BryanStenson-okta: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/cert-manager/aws-privateca-issuer/issues/245): >### Describe why this change is needed > >It would be nice to have topologySpreadConstraints support in the official helm chart > >/kind feature > >### Describe solutions and alternatives considered (optional) > >_No response_ > >### Is there anything else you would like to add? > >_No response_ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
BryanStenson-okta commented 1 year ago

as it was applied to the cert-manager helm chart here: https://github.com/cert-manager/cert-manager/pull/5395

bmsiegel commented 1 year ago

Thank you for submitting your feature request to AWS Private CA Issuer plugin. We will review the request and get back to you

divyansh-gupta commented 1 year ago

Hi @BryanStenson-okta - Thank you for the request. Given the niche use for this, we won't prioritize this work today, but we welcome any PRs from the community adding this support.

BryanStenson-okta commented 1 year ago

PR: https://github.com/cert-manager/aws-privateca-issuer/pull/258

divyansh-gupta commented 1 year ago

Merged, thank you @BryanStenson-okta!