search

cert-manager / aws-privateca-issuer

Addon for cert-manager that issues certificates using AWS ACM PCA.
Apache License 2.0
185 stars 77 forks source link

Use the Docker Build Kit platform vars #265

Closed dave-shawley closed 1 year ago

dave-shawley commented 1 year ago

The Docker Build Kit exports the target OS and architecture as build args so we can use them instead of assuming linux/amd64. The default values are set to linux/amd64 in case you are building in a docker version that does not have build kit available. You may also need to set DOCKER_BUILDKIT=1 for it to export TARGETOS and TARGETARCH correctly.

I'm not sure what incantations are required in the Github actions to build on ARM as well as Intel but this should "just work" if you are building on an ARM CPU. This is a start to addressing #147 though additional CI work is required.

https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope

jetstack-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dave-shawley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/aws-privateca-issuer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment