cert-manager / aws-privateca-issuer

Addon for cert-manager that issues certificates using AWS ACM PCA.

Apache License 2.0

184 stars 77 forks source link

fix: HPA syntax, allow v2 API #290

Closed fernandezcuesta closed 3 weeks ago

fernandezcuesta commented 11 months ago

HPA had apparently an additional field (checked v1 and v2 and none have namespace under scaleTargetRef. Support for HPA v2 added if supported by the target cluster.

jetstack-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/aws-privateca-issuer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

divyansh-gupta commented 11 months ago

Good catch, I don't see namespace here either: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#crossversionobjectreference-v2-autoscaling. Please go ahead and make the change Brady requested and we will approve the PR for testing.

jetstack-bot commented 11 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

bmsiegel commented 3 weeks ago

335 has been merged, closing this one as duplicate