feat: recover from previously failed attempt

cert-manager / aws-privateca-issuer

Addon for cert-manager that issues certificates using AWS ACM PCA.

Apache License 2.0

185 stars 77 forks source link

feat: recover from previously failed attempt #291

Open woehrl01 opened 11 months ago

woehrl01 commented 11 months ago

If a previous certificate request failed, it will be currently never retried again.

This adds a configuration max-retry-duration to allow a transition time to recover from transient errors.

The PR includes:

New Unittests
Fixed existing unittest for cluster wide issuer
go fmt of everything

woehrl01 commented 1 month ago

What kind of unnecessary changes do you refer to, you would like to have moved to a separate PR?

bmsiegel commented 1 month ago

It looks like the CRD changes are not needed for this, correct me if I'm wrong.

woehrl01 commented 1 month ago

I see, yes they are not. They have been a result on regenerating the manifests from the definition. I can remove that, but suggest doing the change afterwards to make contributions easier.

bmsiegel commented 1 month ago

+1, agreed.