Replace deprecated command with environment file

jongwooo commented 9 months ago

Description

Closes #301

Update workflows to use environment file instead of deprecated set-output command. For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

- name: Setup Cache variables
  id: go-cache-paths
  run: |
    echo "::set-output name=go-build::${{ env.GOCACHE }}"
    echo "::set-output name=go-mod::${{ env.GOMODCACHE }}"

TO-BE

- name: Setup Cache variables
  id: go-cache-paths
  shell: bash
  run: |
    echo "go-build=${{ env.GOCACHE }}" >> $GITHUB_OUTPUT
    echo "go-mod=${{ env.GOMODCACHE }}" >> $GITHUB_OUTPUT

bmsiegel commented 6 months ago

This PR ran successfully on my local branch, running testing to make sure nothing is being mutated in the source code, then will merge

jetstack-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/aws-privateca-issuer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

cert-manager / aws-privateca-issuer

Replace deprecated command with environment file #302

Description