search

cert-manager / aws-privateca-issuer

Addon for cert-manager that issues certificates using AWS ACM PCA.
Apache License 2.0
184 stars 77 forks source link

Revert "fix(deps): update k8s.io/utils digest to e7106e6" #309

Closed kollabpr closed 8 months ago

kollabpr commented 8 months ago

Reverting PR #308 as it was merged without testing.

amibhi commented 8 months ago

The test workflow is failing due to #307 updating the Chart version to 1.2.7, so the helm test is looking for that version in ECR:

Jan 03 21:01:47 pca-external-issuer-control-plane containerd[232]: time="2024-01-03T21:01:47.440077277Z" level=error msg="PullImage \"public.ecr.aws/k1n1h4h4/cert-manager-aws-privateca-issuer:v1.2.7\" failed" error="rpc error: code = NotFound desc = failed to pull and unpack image \"public.ecr.aws/k1n1h4h4/cert-manager-aws-privateca-issuer:v1.2.7\": failed to resolve reference \"public.ecr.aws/k1n1h4h4/cert-manager-aws-privateca-issuer:v1.2.7\": public.ecr.aws/k1n1h4h4/cert-manager-aws-privateca-issuer:v1.2.7: not found"

Since this PR reverts a commit and takes us back to a known state, we will merge it. The 1.2.7 release is pending internal approval for changes we've made to the release process. Once the release is complete, the test workflow will succeed as expected and we can begin merging PRs.

jetstack-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/aws-privateca-issuer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment