search

cert-manager / aws-privateca-issuer

Addon for cert-manager that issues certificates using AWS ACM PCA.
Apache License 2.0
184 stars 77 forks source link

feat: add autogenerated helm docs #314

Closed ThatsMrTalbot closed 6 months ago

ThatsMrTalbot commented 8 months ago

There are no docs for the helm chart, this adds auto-generated docs using helm-tool.

Preview can be seen here: https://github.com/ThatsMrTalbot/aws-privateca-issuer/blob/feat/helm-tool-for-docs/charts/aws-pca-issuer/README.md

kollabpr commented 8 months ago

Hi @ThatsMrTalbot - Thanks for the feature request and the PR! We will review with the team and get back to you soon.

ThatsMrTalbot commented 7 months ago

It looks like the failing build has nothing to do with my change, since its failing at the go build stage and the PR does not touch any go code

ThatsMrTalbot commented 6 months ago

Build looks to have passed now, could this be looked at when you get a mo?

jetstack-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/aws-privateca-issuer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment