search

cert-manager / aws-privateca-issuer

Addon for cert-manager that issues certificates using AWS ACM PCA.
Apache License 2.0
184 stars 77 forks source link

fix: hpa v2 api update #335

Closed bbensky closed 3 weeks ago

bbensky commented 1 month ago

There have been a couple similar PRs for this the were never merged in, so just trying to get this finished up: https://github.com/cert-manager/aws-privateca-issuer/pull/290 https://github.com/cert-manager/aws-privateca-issuer/pull/306

bmsiegel commented 1 month ago

Testing failed: https://github.com/cert-manager/aws-privateca-issuer/actions/runs/10406379982/job/28819337862?pr=335

bbensky commented 1 month ago

Testing failed: https://github.com/cert-manager/aws-privateca-issuer/actions/runs/10406379982/job/28819337862?pr=335

Fixed.

bmsiegel commented 1 month ago

Looks like the testing passed. Thanks for the fix. Would you mind squashing these commits into the same one? Will get it merged after that.

bbensky commented 3 weeks ago

@bmsiegel Is it possible to run that failed test again? Looks like it failed testing one specific cert.

cert-manager-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/aws-privateca-issuer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment