feat: Support disabling Kubernetes client side rate limiting

cert-manager / aws-privateca-issuer

Addon for cert-manager that issues certificates using AWS ACM PCA.

Apache License 2.0

184 stars 77 forks source link

feat: Support disabling Kubernetes client side rate limiting #336

Open hexalellogram opened 1 month ago

hexalellogram commented 1 month ago

This should theoretically resolve #334.

Note that I haven't had the chance to test this at all - I believe it works (and I based a good bit of my work on the changes in https://github.com/cert-manager/istio-csr/pull/352 which does the same thing for istio-csr), but I haven't actually proven that out end-to-end by adding unit and integration tests because I don't really have a deep understanding of the test suite here.

This PR includes:

new value in Helm values, disableClientSideRateLimiting
corresponding new command line option
Using this new option to set config.QPS and config.Burst for the Kubernetes REST client

cert-manager-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign munnerz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/aws-privateca-issuer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ARichman555 commented 3 weeks ago

Hi, we're currently in the process of testing this PR to make sure everything works properly! We're currently not seeing any improvements by enabling this so looking into why that may be.