search

cert-manager / cert-manager

Automatically provision and manage TLS certificates in Kubernetes
https://cert-manager.io
Apache License 2.0
11.98k stars 2.07k forks source link

Add support for custom-fields into the ingress annotations #6489

Closed salindaliyanage closed 3 months ago

salindaliyanage commented 10 months ago

Is your feature request related to a problem? Please describe. Our cert-manager implementation uses venafi custom fields (venafi.cert-manager.io/custom-fields) in our certificate resources. We would like to use the annotated Ingress resources for improved automation in our ingresses, but that is not possible as currently the custom fields cannot be passed into the venafi issuer using the ingress annotations.

Describe the solution you'd like Add support for issuer specific custom-fields to the ingress annotations.

Describe alternatives you've considered Request TLS certificate using a certificate resources and use them in ingress

/kind feature

jetstack-bot commented 7 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Send feedback to jetstack. /lifecycle stale

jetstack-bot commented 6 months ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. /lifecycle rotten /remove-lifecycle stale

jetstack-bot commented 5 months ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten. /close

jetstack-bot commented 5 months ago

@jetstack-bot: Closing this issue.

In response to [this](https://github.com/cert-manager/cert-manager/issues/6489#issuecomment-2053770025): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
peteroneilljr commented 5 months ago

I would also like to vote for this feature

Osamaabdalsabour commented 5 months ago

Is your feature request related to a problem? Please describe. Our cert-manager implementation uses venafi custom fields (venafi.cert-manager.io/custom-fields) in our certificate resources. We would like to use the annotated Ingress resources for improved automation in our ingresses, but that is not possible as currently the custom fields cannot be passed into the venafi issuer using the ingress annotations.

Describe the solution you'd like Add support for issuer specific custom-fields to the ingress annotations.

Describe alternatives you've considered Request TLS certificate using a certificate resources and use them in ingress

/kind feature

/Saned Comment my Team's Thank god for you <apiVersion: networking.k8s.io/v1 kind: Ingress metadata: annotations: # add an annotation indicating the issuer to use. cert-manager.io/cluster-issuer: nameOfClusterIssuer name: myIngress namespace: myIngress spec: rules: - host: example.com http: paths: - pathType: Prefix path: / backend: service: name: myservice port: number: 80 tls: # < placing a host in the TLS config will determine what ends up in the cert's subjectAltNames - hosts: - example.com secretName: myingress-cert # < cert-manager will store the created certificate in this secret.>><>

Osamaabdalsabour commented 5 months ago

apiVersion: networking.k8s.io/v1 kind: Ingress metadata: annotations: # add an annotation indicating the issuer to use. cert-manager.io/cluster-issuer: nameOfClusterIssuer name: myIngress namespace: myIngress spec: rules: - host: example.com http: paths: - pathType: Prefix path: / backend: service: name: myservice port: number: 80 tls: # < placing a host in the TLS config will determine what ends up in the cert's subjectAltNames - hosts: - example.com secretName: myingress-cert # < cert-manager will store the created certificate in this secret.

salindaliyanage commented 5 months ago

/reopen

cert-manager-prow[bot] commented 5 months ago

@salindaliyanage: Reopened this issue.

In response to [this](https://github.com/cert-manager/cert-manager/issues/6489#issuecomment-2063410344): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cert-manager-bot commented 3 months ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten. /close

cert-manager-prow[bot] commented 3 months ago

@cert-manager-bot: Closing this issue.

In response to [this](https://github.com/cert-manager/cert-manager/issues/6489#issuecomment-2167853355): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.