search

cert-manager / cert-manager

Automatically provision and manage TLS certificates in Kubernetes
https://cert-manager.io
Apache License 2.0
11.6k stars 2.02k forks source link

Revert in-tree ParseDN function now that upstream ParseDN function has been fixed #6995

Closed inteon closed 3 weeks ago

inteon commented 3 weeks ago

Branched from https://github.com/cert-manager/cert-manager/pull/6775

In https://github.com/cert-manager/cert-manager/pull/6761 we added our own literalSubject parser which follows RFC 4514 and RFC 2253.

Reverts https://github.com/cert-manager/cert-manager/pull/6761.

Since then, the ParseDN implementation in https://github.com/go-ldap/ldap and the https://github.com/go-asn1-ber/asn1-ber library were improved (see https://github.com/go-ldap/ldap/pull/497, https://github.com/go-ldap/ldap/pull/505, https://github.com/go-ldap/ldap/pull/504 and https://github.com/go-asn1-ber/asn1-ber/pull/42). This PR removes our own ParseDN function in favor of this updated upstream parser.

Kind

/kind cleanup

Release Note

NONE
inteon commented 3 weeks ago

/retest

inteon commented 3 weeks ago

/retest

cert-manager-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/cert-manager/blob/master/OWNERS)~~ [wallrj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment