search

cert-manager / cert-manager

Automatically provision and manage TLS certificates in Kubernetes
https://cert-manager.io
Apache License 2.0
11.6k stars 2.02k forks source link

[release-1.12] Bump kind, increase range of supported k8s versions #7021

Closed SgtCoDFish closed 2 weeks ago

SgtCoDFish commented 2 weeks ago

Pull Request Motivation

The old version of kind used by release-1.12 has no support for newer releases of k8s, meaning we can't test cert-manager 1.12 with Kubernetes 1.29 or 1.28. Since 1.12 is a LTS release, we'd ideally want to do that.

Kind v0.20.0 is used by cert-manager 1.13 and 1.14 so we've tested it extensively, and it has a very wide range of supported versions. This PR changes to use that version, thereby allowing us to test more versions of K8s.

Notably v0.20.0 doesn't support Kubernetes v1.30.0 - to solve that, we'll need our own pipeline to build K8s node images unless Kind adds upstream support which is probably unlikely. So for now, we'll take the easy win to get support for testing v1.28 and v1.29 and we'll pass on Kubernetes v1.30.

The kind image script is pulled from the current master branch (https://github.com/cert-manager/cert-manager/blob/1e0a1ae1aa91b3ad4cc9e0ab16ca68de22492485/hack/latest-kind-images.sh).

Kind

/kind cleanup

Release Note

Upgrade Kind to support testing on Kubernetes v1.28 and v1.29
cert-manager-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sgtcodfish. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/cert-manager/blob/release-1.12/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SgtCoDFish commented 2 weeks ago

/test ?

cert-manager-prow[bot] commented 2 weeks ago

@SgtCoDFish: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/cert-manager/cert-manager/pull/7021#issuecomment-2110219931): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
SgtCoDFish commented 2 weeks ago

/test pull-cert-manager-release-1.12-e2e-v1-26

cert-manager-prow[bot] commented 2 weeks ago

@SgtCoDFish: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-release-1.12-e2e-v1-27 2df381d833d351815ed90efa86f9f4547154a789 link true /test pull-cert-manager-release-1.12-e2e-v1-27
pull-cert-manager-release-1.12-e2e-v1-27-upgrade 2df381d833d351815ed90efa86f9f4547154a789 link true /test pull-cert-manager-release-1.12-e2e-v1-27-upgrade
pull-cert-manager-release-1.12-e2e-v1-26 2df381d833d351815ed90efa86f9f4547154a789 link false /test pull-cert-manager-release-1.12-e2e-v1-26

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
SgtCoDFish commented 2 weeks ago

Closing in favour of #7029