Feature/5514 - Add SecretRef support for venafi TPP issuer CA Bundle

[sankalp-at-gh]

Pull Request Motivation

To address issue #5514 so that we would no longer need to pass long CA Bundles but could just have a reference to a secret or configmap having the bundle. Having support for secret ref will also allow reading CAs distributed by trust-manager

As per below example, any of one of the fields caBundle or caBundleSecretRef would be supported to read the CA bundle

spec:
  venafi:
    tpp:
      caBundle: <B64_ENCODED_STRING>
      caBundleSecretRef:
        name: <>
        key: <>
      credentialsRef:
        name: tpp-token
      url: https://my-server.com/vedsdk/
    zone: Certificates\public

All of the controllers, testcases and rbac have been updated to support this functionality

Kind

feature

Release Note

Add SecretRef support for venafi TPP issuer CA Bundle

[cert-manager-prow[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign wallrj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/cert-manager/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[cert-manager-prow[bot]]

Hi @sankalp-at-gh. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[sankalp-at-gh]

Thanks for the quick review 🙂 Sure, I'll wait for a thorough review and comments if any

[sankalp-at-gh]

Hi @erikgb !

When you get some time, could you please review this PR as discussed in slack. It has been quiet some time since the PR and I hope the changes have not diverged much. Thanks ! 🙂

[maelvls]

Can someone else help with review the Go implementation?

[inteon]

/ok-to-test

[cert-manager-prow[bot]]

@sankalp-at-gh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cert-manager-master-make-verify	adc7cd0f0662166822ee1294236cfc0505bb371c	link	true	/test pull-cert-manager-master-make-verify
pull-cert-manager-master-make-test	adc7cd0f0662166822ee1294236cfc0505bb371c	link	true	/test pull-cert-manager-master-make-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).