search

cert-manager / community

Contribution and Collaboration Guidelines for the cert-manager Project
https://cert-manager.io
Apache License 2.0
3 stars 5 forks source link

Governance: I realized that GitHub Members do have privileges and can `/close` and `/ok-to-test` #12

Closed maelvls closed 1 year ago

maelvls commented 1 year ago

After reading https://github.com/kubernetes/community/blob/master/community-membership.md#responsibilities-and-privileges, I realized that our own Prow system is configured in the same way. For example, GitHub Members can /close or /ok-to-test ~but also /lgtm~.

~I also discovered that the reviewers section in the OWNERS file isn't actually used to select who can /lgtm. It is only used by Blunderbuss to suggest automatically a reviewer for a pull request that was just submitted.~

~Any collaborator on the repo (i.e., members of the GitHub org) may use the /lgtm command, whether or not they are selected as a reviewer or approver by this plugin. (See the section Blunderbuss Selection Mechanism for reviewer and approver selection algorithm.)~

~I am unsure whether this change requires an explicit approval from all the maintainers since it aims at reflecting what the current situation is, but I think we should have a discussion whether we are OK with the fact that GitHub Members are able to /lgtm.~

Update: as Tim pointed out, /lgtm is correctly restricted to Reviewers.

maelvls commented 1 year ago

I have updated the GOVERNANCE to "just" document the commands that GitHub Members can do today.

JoshVanL commented 1 year ago

/lgtm /approve

jetstack-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/community/blob/main/OWNERS)~~ [JoshVanL] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment