search

cert-manager / community

Contribution and Collaboration Guidelines for the cert-manager Project
https://cert-manager.io
Apache License 2.0
3 stars 5 forks source link

Request maintainer status for @ThatsMrTalbot #23

Closed ThatsMrTalbot closed 6 months ago

ThatsMrTalbot commented 7 months ago

Further to our conversation during standup and following the steps laid out in the GOVERNANCE.md I am requesting maintainer status:

Any existing Approver can become a cert-manager maintainer. Maintainers should be proficient in Go; have expertise in at least one of the domains (Kubernetes, PKI, ACME); have the time and ability to meet the maintainer expectations above; and demonstrate the ability to work with the existing maintainers and project processes.

To become a maintainer, start by expressing interest to existing maintainers. Existing maintainers will then ask you to demonstrate the qualifications above by contributing PRs, doing code reviews, and other such tasks under their guidance. After several months of working together, maintainers will decide whether to grant maintainer status.

As part of my Venafi role part of my responsibilities is to contribute to cert-manager, so I have the time and availablity to meet the maintainer expectations. As for my proficiency, I hope my work with you in the last 5 months has shown this.

Based on the governance document it was not clear how "maintainers will decide whether to grant maintainer status" so it was decided on the call that we would use "lazy consensus" as described in the "Maintainer Decision-Making" documentation. This can be done as comments on this PR for visibility.

SgtCoDFish commented 7 months ago

Fully support this; Adam does a lot of good work! He's been heavily involved in the makefile modules stuff for example.

He's also paid to work on cert-manager at least part of the time - it makes sense for him to be able to do things like releases. He volunteered to do the release of 1.15 and more support with releases is always welcome!

Full disclosure: Adam also works at Venafi so I'm not entirely impartial. I would support his maintainership if I were at any company but it's important to be transparent on that.

maelvls commented 6 months ago

(Disclaimer: Adam is my colleague)

Adam has been improving many parts of the cert-manager project and has been reviewing and falicitating contributions in 246 PRs among 33 projects (!!!) and has been instrumental to projects such as the Makefile Modules project.

Adam has also been helping with issues, and has also helped users in the #cert-manager channel.

I am in favor of adding Adam as a maintainer!

inteon commented 6 months ago

Thanks everyone for voting, we reached the end of the lazy consensus period (https://kubernetes.slack.com/archives/CDEQJ0Q8M/p1714386002098739). The following maintainers are in favor of the change:

There were no votes against.

👍 @ThatsMrTalbot has been accepted as a new maintainer.

Thanks for your past and future contributions to the cert-manager project, @ThatsMrTalbot.

/approve /lgtm

cert-manager-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/community/blob/main/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SgtCoDFish commented 6 months ago

PSA: I've added Adam to the cert-manager-maintainers and cert-manager-security mailing lists.

maelvls commented 6 months ago

To be done next (somewhat documented in https://github.com/cert-manager/infrastructure):

Btw I found that https://github.com/cncf/toc/blob/main/docs/PROJECTS.csv still says that cert-manager is Sandbox 😅

SgtCoDFish commented 6 months ago

I can confirm @ThatsMrTalbot is an "owner" (equivalent to "admin") on the GitHub org 👍

maelvls commented 5 months ago

@ThatsMrTalbot I've just noticed that you aren't "Owner" in the YouTube Brand Account https://myaccount.google.com/brandaccounts/101688634375640008002/view. Each maintainer should have access to it. I've added you using your email adam.talbot@jetstack.io so you can upload videos to the cert-manager channel if you ever need.