search

cert-manager / community

Contribution and Collaboration Guidelines for the cert-manager Project
https://cert-manager.io
Apache License 2.0
3 stars 5 forks source link

Add erikgb as maintainer #32

Closed inteon closed 3 months ago

inteon commented 4 months ago

Erik (@erikgb) has been an important contributor to cert-manager and more specifically trust-manager.

Adding Erik as a maintainer will diversify our maintainers team and it will allow us to give him admin privileges on the trust-manager project, so he can cut releases of trust-manager when required (see https://github.com/cert-manager/community/blob/main/GOVERNANCE.md for requirements wrt. admins).

I (@inteon) think @erikgb is an important part of our community and for that reason must receive the privileges required to contribute optimally. I would trust @erikgb with more admin privileges, but think it is better to restrict his privileges to the actions he is interested in (in case of compromise of his account), additionally this will reduce the scope of the perceived responsibilities that come with these privileges (both for Erik and the rest of the community, eg. no one will ping him to do a cert-manager release).

I'd like us to approve this appointment using lazy consensus:

🧑‍💻 Participants: @cert-manager-maintainers 📢 Deadline: July 19th, 2024 23:59 UTC 🚨 Note: to speed up the process, you may answer with a 👍 or a comment stating that you are lazy to help reach consensus before the deadline.

SgtCoDFish commented 4 months ago

Erik has been the MVP of the cert-manager community for a long time. He's active in meetings, highly knowledgable, and a good person to chat to.

I fully support his nomination and I fully support this proposal 👍

inteon commented 4 months ago

NOTE: this vote has been accepted.

I'm on holiday right now, so I won't be able to make the administrative changes until I'm back. Other maintainers might be able to make them sooner.

SgtCoDFish commented 4 months ago

Erik is also on holiday at the moment, so there's no great rush on this!

maelvls commented 3 months ago

Pre-Onboarding Checklist — info to be requested to the new maintainer:

Onboarding Checklist — tasks to be performed by an existing maintainer:

Onboarding Maintainer: @inteon

Don't forget to add the links to the various PRs or IT tickets as you complete the tasks, and add any missing item.

Initial Privileges:

Self-access Privileges:

Privileges added outside of the CNCF Service Desk:

These are the list of privileges that weren't asked through a ticket at servicedesk.cncf.io because this service isn't owned by the CNCF yet.

maelvls commented 3 months ago

@inteon Thanks for taking care of the onboarding checklist. Feel free to edit the checklist message above with your progress (PR link, etc) sor any additional steps that isn't in the list.

maelvls commented 3 months ago

Not sure why this PR hasn't been merged yet 😅

The lazy-consensus vote ended on July 19th, 2024, which means this PR can be approved.

/lgtm /approve

cert-manager-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/community/blob/main/OWNERS)~~ [maelvls] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment