cert-manager / csi-lib

A library for building CSI drivers that request certificates from cert-manager
Apache License 2.0
14 stars 13 forks source link

Add extra comments to exponential backoff code #14

Closed munnerz closed 3 years ago

munnerz commented 3 years ago

As per https://github.com/cert-manager/csi-lib/pull/7/files#r642272755 - adds some additional comments explaining the values chosen for exponential backoff :)

/assign @JoshVanL /cc @maelvls

jetstack-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/csi-lib/blob/main/OWNERS)~~ [munnerz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JoshVanL commented 3 years ago

/lgtm