cert-manager / csi-lib

A library for building CSI drivers that request certificates from cert-manager
Apache License 2.0
14 stars 13 forks source link

Upgrade vendor #43

Closed 7ing closed 1 year ago

7ing commented 1 year ago

Signed-off-by: Jing Liu jingliu@apple.com

jetstack-bot commented 1 year ago

Hi @7ing. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
inteon commented 1 year ago

/ok-to-test

7ing commented 1 year ago

@inteon The test was failed due to Conflicting files go.mod..... but this PR is about to change this file...

# k8s.io/component-base/metrics
../../../../pkg/mod/k8s.io/component-base@v0.26.1/metrics/registry.go:35:29: undefined: atomic.Bool
note: module requires Go 1.19

Does the pull-cert-manager-csi-lib-verify script need to be updated ?

7ing commented 1 year ago

Still same issue. The pull-cert-manager-csi-lib-verify does not use go 1.19 module.

inteon commented 1 year ago

Still same issue. The pull-cert-manager-csi-lib-verify does not use go 1.19 module.

If you create a PR to upgrade the go version to 1.19, I'll approve it: https://github.com/jetstack/testing/blob/master/config/jobs/cert-manager/csi-lib/cert-manager-csi-lib-presubmits.yaml

7ing commented 1 year ago

Thanks @inteon , good to know. Here is the PR: https://github.com/jetstack/testing/pull/797

inteon commented 1 year ago

/approve /lgtm

munnerz commented 1 year ago

/approve

jetstack-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 7ing, inteon, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/csi-lib/blob/main/OWNERS)~~ [munnerz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment