search

cert-manager / helm-tool

helm-tool is an internal cert-manager utility (can be broken or removed) which generates Helm docs, schema files and performs linting.
Apache License 2.0
5 stars 3 forks source link

Cert-manager chart v1.16.0 Schema validation - Issue with global parameters #46

Closed CeddaerrixGE closed 2 weeks ago

CeddaerrixGE commented 3 weeks ago

I have an umbrella chart having cert-manager as a dependency with custom hooks to configure Issuers on post-install/upgrade. With version v1.16.0, the breaking change about Helm schema validation rejects all the global parameters it does not recognize.

The definition of global (see https://helm.sh/docs/chart_template_guide/subcharts_and_globals/#global-chart-values) is:

Global values are values that can be accessed from any chart or subchart by exactly the same name.

Hence, the helm-tool mentioned under https://cert-manager.io/docs/releases/release-notes/release-notes-1.16/#helm should not reject unknown global and raise an error such as: image Instead, it should either ignore the global parameters or just mark them as a warning that they are not recognize by cert-manager.

CeddaerrixGE commented 3 weeks ago

After a little research, it seems that using patternproperties would be a way to allow global parameters not required by cert-manager

ThatsMrTalbot commented 3 weeks ago

With #43 globals no longer sets additionalProperties: false. This was to solve similar issues like https://github.com/cert-manager/cert-manager/issues/7329

This should solve your issue once we release cert-manager 1.16.1

CeddaerrixGE commented 3 weeks ago

With #43 globals no longer sets additionalProperties: false. This was to solve similar issues like cert-manager/cert-manager#7329

This should solve your issue once we release cert-manager 1.16.1

Any ETA about cert-manager 1.16.1 release?

inteon commented 2 weeks ago

We just released cert-manager v1.16.1.

See https://cert-manager.io/docs/releases/release-notes/release-notes-1.16/#v1161