search

cert-manager / istio-csr

istio-csr is an agent that allows for Istio workload and control plane components to be secured using cert-manager.
https://cert-manager.io/docs/usage/istio-csr/
Apache License 2.0
154 stars 59 forks source link

Add support for s390x for istio-csr #323

Closed rishikakedia closed 2 weeks ago

rishikakedia commented 1 month ago

Adding s390x architecture support to istio-csr. This is required for integration of cert-manager with istio/servicemesh.

cert-manager-prow[bot] commented 1 month ago

Hi @rishikakedia. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rishikakedia commented 1 month ago

@SgtCoDFish please review this PR.

SgtCoDFish commented 1 month ago

/ok-to-test

SgtCoDFish commented 1 month ago

Sorry, that test failed because of an upstream change. We'll update.

SgtCoDFish commented 1 month ago

Once https://github.com/cert-manager/istio-csr/pull/321 merges you can rebase and the tests should start passing

SgtCoDFish commented 1 month ago

OK, now that #321 is merged you should be able to rebase this PR against the main branch and hopefully the tests will pass!

ThatsMrTalbot commented 4 weeks ago

Hiya @rishikakedia

Everything in make/_shared is vendored in, so the check is failing because it is detecting drift between the upstream file due to your changes.

Instead you want to add oci_platforms := linux/amd64,linux/arm/v7,linux/arm64,linux/ppc64le,linux/s390x to make/00_mod.mk as that is the file we put config in for the local repo.

ThatsMrTalbot commented 2 weeks ago

Our DCO check requires all commits are signed-off, I think the easiest thing is to do the following:

# Reset all changes
git reset --hard origin/main
# Bring in the commit with the change to make/00_mod.mk
git cherry-pick 5afed48273649b0fe7b038df5907bf5ea50cabb9
# Signoff the commit so it passes the DCO check
git commit --amend --no-edit --signoff
# Force push the branch
git push -f
rishikakedia commented 2 weeks ago

@ThatsMrTalbot - thanks for your comments

ThatsMrTalbot commented 2 weeks ago

/test pull-cert-manager-istio-csr-k8s-v1-26-istio-v1-14

ThatsMrTalbot commented 2 weeks ago

All tests passing now, thank you for contributing!

/lgtm /approve

cert-manager-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThatsMrTalbot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/istio-csr/blob/main/OWNERS)~~ [ThatsMrTalbot] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment