cert-manager / makefile-modules

Reusable Makefile modules that can be kloned into your project
Apache License 2.0
1 stars 10 forks source link

Publish SBOMs #154

Open SgtCoDFish opened 6 months ago

SgtCoDFish commented 6 months ago

I can see that SBOMs are generated by make oci-build-manager in trust-manager. It looks like these would be helpful to publish in releases, and it shouldn't be hard to add them to github releases.

I'd actually assumed we were publishing these but it doesn't seem like we are!

For example, on the v0.10.0 tag of trust-manager:

$ ls _bin/scratch/image/oci-layout-manager.v0.10.0.sbom
trust-manager-index.spdx.json
trust-manager-linux-amd64.spdx.json
trust-manager-linux-arm-v7.spdx.json
trust-manager-linux-arm64.spdx.json
trust-manager-linux-ppc64le.spdx.json
inteon commented 6 months ago

I can confirm: we have not yet implemented sbom pushing. Important to consider here:

wallrj commented 4 months ago

Maybe related, I just noticed the following warning when doing an approver-policy-enterprise release:

WARNING: SBOM attachments are deprecated and support will be removed in a Cosign release soon after 2024-02-22 (see https://github.com/sigstore/cosign/issues/2755). Instead, please use SBOM attestations.