search

cert-manager / testing

Repository containing cert-manager testing infrastructure configuration
3 stars 30 forks source link

Change periodic cert-manager jobs to use cron #1003

Closed SgtCoDFish closed 6 months ago

SgtCoDFish commented 6 months ago

This spreads the jobs pretty well throughout the day to try and minimise the amount of compute we're using for any one instant of cert-manager tests.

This algorithm seems to give reasonable performance in spread without spending too much time digging into making it perfect.

I've attempted to comment it as much as possible because I know it's likely to be harder to read than it was to write.

inteon commented 6 months ago

Thanks @SgtCoDFish. Took me some time to understand everything (had to refresh some of my cron-knowledge). I have 2 remarks/ questions, but the PR seems to be good to go as-is, I think. /approve /lgtm /hold in case you want to still address those two comments.

cert-manager-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/testing/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
inteon commented 6 months ago

/unhold

cert-manager-prow[bot] commented 6 months ago

@SgtCoDFish: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/cert-manager/testing/pull/1003): >This spreads the jobs pretty well throughout the day to try and minimise the amount of compute we're using for any one instant of cert-manager tests. > >This algorithm seems to give reasonable performance in spread without spending too much time digging into making it perfect. > >I've attempted to comment it as much as possible because I know it's likely to be harder to read than it was to write. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.