search

cert-manager / testing

Repository containing cert-manager testing infrastructure configuration
3 stars 29 forks source link

Dont use kube-dns, use 8.8.8.8 directly #1012

Closed inteon closed 4 months ago

inteon commented 5 months ago

None of our tests need to access services inside the cluster, to reduce the load and dependance on kube-dns; we let the tests contact google's public dns servers directly. The goal is to make the tests more resilient for kube-dns outages (eg. due to spot instance shutdown).

ThatsMrTalbot commented 4 months ago

/lgtm

inteon commented 4 months ago

/approve

cert-manager-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/testing/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cert-manager-prow[bot] commented 4 months ago

@inteon: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/cert-manager/testing/pull/1012): >None of our tests need to access services inside the cluster, to reduce the load and dependance on kube-dns; we let the tests contact google's public dns servers directly. >The goal is to make the tests more resilient for kube-dns outages (eg. due to spot instance shutdown). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.