search

cert-manager / testing

Repository containing cert-manager testing infrastructure configuration
3 stars 30 forks source link

Run gencred less frequently since it causes prow components to restart #1015

Closed inteon closed 6 months ago

inteon commented 6 months ago

Every time that gencred renews its jwt tokens, all components that have this token mounted restart. This is because they detected a change and want to load the new token (no dynamic loader seems to be implemented by prow yet). To reduce the amount of restarts, I propose to make the jwts last longer and refresh them less frequently.

ThatsMrTalbot commented 6 months ago

/lgtm

inteon commented 6 months ago

/approve

cert-manager-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/testing/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cert-manager-prow[bot] commented 6 months ago

@inteon: Updated the gencred-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/cert-manager/testing/pull/1015): >Every time that gencred renews its jwt tokens, all components that have this token mounted restart. >This is because they detected a change and want to load the new token (no dynamic loader seems to be implemented by prow yet). >To reduce the amount of restarts, I propose to make the jwts last longer and refresh them less frequently. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.