search

cert-manager / testing

Repository containing cert-manager testing infrastructure configuration
3 stars 30 forks source link

Rename required GH status for website PRs #1037

Closed inteon closed 4 months ago

inteon commented 4 months ago

Now that we unified and moved the cert-manager.io Netlify setup to the CNCF Netlify account, the GH status that checks that the preview was deployed correctly has a different name.

Currently, we have two statuses: image

The goal is to only have one status netlify/cert-manager/deploy-preview and have that status as the required status.

ThatsMrTalbot commented 4 months ago

/lgtm

inteon commented 4 months ago

/approve

cert-manager-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/testing/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cert-manager-prow[bot] commented 4 months ago

@inteon: Updated the config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/cert-manager/testing/pull/1037): >Now that we unified and moved the cert-manager.io Netlify setup to the CNCF Netlify account, the GH status that checks that the preview was deployed correctly has a different name. > >Currently, we have two statuses: >![image](https://github.com/cert-manager/testing/assets/42113979/a308cff9-f097-4b8c-aefd-a036f2721a10) > >The goal is to only have one status `netlify/cert-manager/deploy-preview` and have that status as the required status. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.