search

cert-manager / testing

Repository containing cert-manager testing infrastructure configuration
3 stars 30 forks source link

Remove unused K8S_VERSION environment variable from istio-csr tests #1044

Closed inteon closed 3 months ago

inteon commented 3 months ago

Currently, the K8S_VERSION environment variable is ignored when running istio-csr tests. To avoid confusion, I propose to not set the variable in the tests and rename the tests so it is clear they all just use the kubernetes version defined in the repo.

We might want to add support for configurable K8S_VERSION in the future. The K8S_VERSION defined today are however just random and unuseful.

cert-manager-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/testing/blob/master/OWNERS)~~ [SgtCoDFish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cert-manager-prow[bot] commented 3 months ago

@inteon: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/cert-manager/testing/pull/1044): >Currently, the K8S_VERSION environment variable is ignored when running istio-csr tests. >To avoid confusion, I propose to not set the variable in the tests and rename the tests so it is clear they all just use the kubernetes version defined in the repo. > >We might want to add support for configurable K8S_VERSION in the future. The K8S_VERSION defined today are however just random and unuseful. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.