search

cert-manager / testing

Repository containing cert-manager testing infrastructure configuration
3 stars 30 forks source link

Add test-e2e-ambient for 1.22 release #1050

Closed paulwilljones closed 2 months ago

paulwilljones commented 3 months ago

⚠️ Only merge after https://github.com/cert-manager/istio-csr/pull/336

cert-manager-prow[bot] commented 3 months ago

Hi @paulwilljones. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
inteon commented 2 months ago

@SgtCoDFish do we still have to merge this? Also, is the test-e2e-pure-runtime target being called anywhere already? A cleaner solution might be to bundle these targets in the istio-csr repo under test-e2e and just keep calling a single Makefile target here.

SgtCoDFish commented 2 months ago

Yeah this needs to merge I think. I don't think it's the end of the world that it hasn't gone in yet though!

I'm open to reworking how these tests are called down the road as long as each e2e test can still easily be run individually!

SgtCoDFish commented 2 months ago

/retest

SgtCoDFish commented 2 months ago

Oh, maybe this should run as a separate test rather than being tacked onto an existing one 🤔 I'll sort that out

SgtCoDFish commented 2 months ago

@inteon I've changed this to add pure runtime tests + ambient tests as separate targets 👍

cert-manager-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/testing/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cert-manager-prow[bot] commented 2 months ago

@paulwilljones: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/cert-manager/testing/pull/1050): >⚠️ Only merge after https://github.com/cert-manager/istio-csr/pull/336 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.