search

cert-manager / testing

Repository containing cert-manager testing infrastructure configuration
3 stars 30 forks source link

Add note explaining where a required check is defined #1055

Closed SgtCoDFish closed 2 months ago

SgtCoDFish commented 2 months ago

In https://github.com/cert-manager/testing/pull/789 we removed the presubmit from this repo, but the test is still marked as required for the website repo.

This test is defined in the website repo instead.

ThatsMrTalbot commented 2 months ago

/lgtm /approve

SgtCoDFish commented 2 months ago

/hold

cert-manager-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThatsMrTalbot, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/testing/blob/master/OWNERS)~~ [wallrj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SgtCoDFish commented 2 months ago

/unhold

I'm fine with the name, just think this needs documenting clearly because we run the website tests differently to how we run presubmits elsewhere!

cert-manager-prow[bot] commented 2 months ago

@SgtCoDFish: Updated the config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/cert-manager/testing/pull/1055): >In https://github.com/cert-manager/testing/pull/789 we removed the presubmit from this repo, but the test is >still marked as required for the website repo. > >This test is defined in the website repo instead. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.