cert-manager / testing

Repository containing cert-manager testing infrastructure configuration
3 stars 30 forks source link

Add dashboard group for istio-csr, fix comment #1068

Closed SgtCoDFish closed 1 week ago

SgtCoDFish commented 1 week ago
inteon commented 1 week ago

The PR looks good to me, I think the best way to figure out if it will work is to merge it. /approve /lgtm

cert-manager-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/testing/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cert-manager-prow[bot] commented 1 week ago

@SgtCoDFish: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/cert-manager/testing/pull/1068): >- Adds a couple of annotations which seem obvious (see https://github.com/kubernetes/test-infra/blob/master/testgrid/config.md) >- Fixes times given in comment on cron field; I mistakenly used BST rather than UTC >- Moves the new istio-csr dashboard to a group called "cert-manager-subprojects" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
SgtCoDFish commented 1 week ago

It worked! https://testgrid.k8s.io/cert-manager-subprojects