search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
255 stars 69 forks source link

Vendor dependencies correctly #194

Closed SgtCoDFish closed 1 year ago

SgtCoDFish commented 1 year ago

Make won't update files when a variable changes unless that variable is somehow included as a dependency for a target or in the path of the name of the target.

This commit adds versions to the paths of all tools we depend on, so that when one user bumps version numbers, everyone else won't need to run make clean.

SgtCoDFish commented 1 year ago

Follow up to #192

inteon commented 1 year ago

/approve /lgtm

jetstack-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment