search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
246 stars 66 forks source link

allow setting namespace for helm chart #198

Closed vinny-sabatini closed 11 months ago

vinny-sabatini commented 11 months ago

This is based on cert-manager's helm chart override and resolves #145

jetstack-bot commented 11 months ago

Hi @vinny-sabatini. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vinny-sabatini commented 11 months ago

This addresses #198

erikgb commented 11 months ago

This addresses #198

@vinny-sabatini, thanks for looking into this. I believe this PR should resolve https://github.com/cert-manager/trust-manager/issues/145? Can you please add a proper description to the PR?

vinny-sabatini commented 11 months ago

@vinny-sabatini, thanks for looking into this. I believe this PR should resolve https://github.com/cert-manager/trust-manager/issues/145? Can you please add a proper description to the PR?

Whoops, wrong link 😅 thanks @erikgb ! I have updated the description on the PR.

erikgb commented 11 months ago

/retest

erikgb commented 11 months ago

/assign @SgtCoDFish @inteon

jetstack-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [SgtCoDFish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment