search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
255 stars 69 forks source link

Remove patch versions from go directives #209

Closed SgtCoDFish closed 1 year ago

SgtCoDFish commented 1 year ago

This helps older versions of go parse these directives

Specifically, our build process for the default trust package locally depends on trust-manager@main, but older releases (the release-0.6 branch) use go 1.20 and won't be able to parse them.

This tangle isn't ideal, but for future versions (i.e. when we can retire the release-0.6 branch and all supported versions use go 1.21) we can move past this and add the patch releases to our go directives again.

Motivation: This test failure for the release-0.6 branch. Specifically:

15 20.52 go: github.com/cert-manager/trust-manager/cmd/validate-trust-package@main (in github.com/cert-manager/trust-manager@v0.7.0-alpha.2.0.20231024102130-94e8d110291e): go.mod:3: invalid go version '1.21.3': must match format 1.23

inteon commented 1 year ago

/approve /lgtm

jetstack-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment