search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
255 stars 69 forks source link

BUGFIX: support switching between target types #211

Closed inteon closed 1 year ago

inteon commented 1 year ago

Missed in https://github.com/cert-manager/trust-manager/pull/193

On master, switching from the ConfigMap target type to the Secret target type was not supported correctly (or vice-versa). I added additional tests and fixed this bug in this PR.

inteon commented 1 year ago

/test pull-trust-manager-smoke

jetstack-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [SgtCoDFish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Jiawei0227 commented 1 year ago

I remember I explicitly add validation webhook to prevent switch target types just for ease of maintainance of the code :) Thanks for adding the support tho