search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
246 stars 66 forks source link

Add erikgb to project approvers #216

Closed erikgb closed 10 months ago

erikgb commented 10 months ago

Ref. the cert-manager governance document, I would like to apply for the approver role in trust-manager.

Since becoming a reviewer, I have reviewed several PRs in this project. Many small ones, but also some larger ones. In the last category I would like to mention: https://github.com/cert-manager/trust-manager/pull/89 https://github.com/cert-manager/trust-manager/pull/161 https://github.com/cert-manager/trust-manager/pull/178 https://github.com/cert-manager/trust-manager/pull/184 https://github.com/cert-manager/trust-manager/pull/198

Sponsor: @inteon

inteon commented 10 months ago

This is a no-brainer. I'm delighted to add you to the approvers list.

/approve /lgtm

jetstack-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
erikgb commented 10 months ago

This is a no-brainer. I'm delighted to add you to the reviewers list.

Thanks a lot @inteon. I hope you know that this PR made me an approver. I already had reviewer status. 😉

inteon commented 10 months ago

Thanks a lot @inteon. I hope you know that this PR made me an approver. I already had reviewer status. 😉

I noticed, but wrote down the wrong word.

Also, for the record, I checked that the approver requirements have been fulfilled.