search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
244 stars 66 forks source link

Allow permissions to put the leases in the trust-manager namespace, not the trust namespace #225

Closed tspearconquest closed 10 months ago

tspearconquest commented 10 months ago

This pull request separates the lease permissions to their own role and role binding in the namespace where trust-manager will be installed. See #224 for more details.

jetstack-bot commented 10 months ago

Hi @tspearconquest. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
erikgb commented 10 months ago

/ok-to-test

tspearconquest commented 10 months ago

Sounds good. Is there anything I need to do in order to mention this in the release notes, or will it be taken care of in the release?

erikgb commented 10 months ago

/lgtm

erikgb commented 10 months ago

/cc @wallrj @SgtCoDFish @inteon

I am tempted to approve this as well, but since my approver status is very fresh, I don't want to do anything wrong. 👼

jetstack-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [SgtCoDFish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
erikgb commented 8 months ago

/cherrypick release-0.7

jetstack-bot commented 8 months ago

@erikgb: new pull request created: #263

In response to [this](https://github.com/cert-manager/trust-manager/pull/225#issuecomment-1873778292): >/cherrypick release-0.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.