cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
256 stars 69 forks source link

Way to add labels/annotations to target #23

Open james-callahan opened 2 years ago

james-callahan commented 2 years ago

I would like to be able to add labels and annotations to the target.

59977 commented 2 years ago

I would also like to do that.

My use case is in combination with https://github.com/stakater/Reloader. I would like to set the reloader.stakater.com/match annotation.

erikgb commented 1 year ago

If ever implemented, I think we should get inspiration from the secretTemplate in cert-manager Certificate.

erikgb commented 1 year ago

/good-first-issue

jetstack-bot commented 1 year ago

@erikgb: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/cert-manager/trust-manager/issues/23): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knaruf commented 1 year ago

As a work around you can pre-create the configmap like this:

apiVersion: v1
kind: ConfigMap
metadata:
  name: {{ .Values.bundle.name }}
  annotations:
    reloader.stakater.com/match: "true"

Trust manager will then use this existing configmap to add the bundle to and the annotation is set.

DuraCHYo commented 1 month ago

Hi! Are there any updates? Flagger due to the lack of the ability to add

annotations:
 flagger.app/config-tracking: disabled

creates new ConfigMaps from application dependencies