search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
244 stars 66 forks source link

Add two new variables to the Helm chart #232

Closed bodgit closed 6 months ago

bodgit commented 10 months ago
jetstack-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign maelvls for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jetstack-bot commented 10 months ago

Hi @bodgit. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bodgit commented 7 months ago

@inteon did you have any further feedback?

jetstack-bot commented 7 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
SgtCoDFish commented 6 months ago

Gonna close this since we went a different way with it! Thanks so much @bodgit for raising something - appreciate you getting involved even if we didn't merge this ❤️

bodgit commented 6 months ago

Gonna close this since we went a different way with it! Thanks so much @bodgit for raising something - appreciate you getting involved even if we didn't merge this ❤️

I will redo the PR for just the revisionHistoryLimit settings.

SgtCoDFish commented 6 months ago

Ah sorry - I missed that part entirely!

Yeah if you raise a PR I'll take a look at that. Please feel free to assign it to me and ping me for a review!