Closed erikgb closed 9 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from erikgb. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/retest
This PR makes use of the Bundle API apply configurations introduced in https://github.com/cert-manager/trust-manager/pull/217. The PR also suggests an alternative approach to do SSA using the controller-runtime client. You might have good reasons for keeping the existing approach, but we are using the alternative approach proposed in this PR with success. And it is at least more compact in code measures. Please let me know what you think.
I am planning to simplify even more, by just using
BundleStatusApplyConfiguration
, after/if https://github.com/cert-manager/trust-manager/pull/236 is merged. The utility functions to handleneedsUpdate
is blocking a well-written SSA reconciler IMO. 😉/cc @inteon @SgtCoDFish