Closed arsenalzp closed 8 months ago
Hi @arsenalzp. Thanks for your PR.
I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
PR needs rebase.
I did a pass of the API changes, and I think we need more work before this eventually can be merged. On second thought, I think this issue was not a "good first issue" after all, especially after we decided to include this change in the API. Sorry about that. But please try to finish, @arsenalzp. I can try to assist. Let's keep focus on the API changes first, as that is the most important part to get right.
Thank you for your review, I will take into account all your remarks! No, this issue doesn't look complicated for me, however it is only hard to troubleshoot tests :-)
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
It is another PR related to #199 . It adds PKCS12 arbitrary password feature into Bundle resource for each store: JKS and PKCS12.