search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
243 stars 65 forks source link

add PKCS12 arbitrary password feature #244

Closed arsenalzp closed 8 months ago

arsenalzp commented 9 months ago

It is another PR related to #199 . It adds PKCS12 arbitrary password feature into Bundle resource for each store: JKS and PKCS12.

jetstack-bot commented 9 months ago

Hi @arsenalzp. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jetstack-bot commented 8 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
arsenalzp commented 8 months ago

I did a pass of the API changes, and I think we need more work before this eventually can be merged. On second thought, I think this issue was not a "good first issue" after all, especially after we decided to include this change in the API. Sorry about that. But please try to finish, @arsenalzp. I can try to assist. Let's keep focus on the API changes first, as that is the most important part to get right.

Thank you for your review, I will take into account all your remarks! No, this issue doesn't look complicated for me, however it is only hard to troubleshoot tests :-)

jetstack-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment