Closed SgtCoDFish closed 8 months ago
Thanks Ash! I am just dreaming of a Mac! 😉 I have also verified that this still works on my Windows-Ubuntu.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: erikgb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I noticed this while looking into #240
Commit 1
On at least macos 14.1 (sonoma) the paste utility seems to require a filename to be specified; before this change, the
API_DIRS
variable fails with the following error:Commit 2
This avoids us spinning up a separate shell when evaluating
API_DIRS
, sinceGO_MODULE
already contains the value we want.This change also changes the variable assignments; make variables are very confusing, but
:=
should only evaluate at startup while=
will evaluate every time the variable is used.See these docs for how
=
works, and these for:=
. From the first link: