search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
243 stars 65 forks source link

BREAKING: chore: align BundleCondition with upstream metav1.Condition #249

Closed erikgb closed 8 months ago

erikgb commented 8 months ago

This is a PR that replaces https://github.com/cert-manager/trust-manager/pull/240. Since we decided to not migrate to the upstream metav1.Condition, I have tried to align our own BundleCondition as much as possible the the current upstream struct. Personally, I think it's an improvement that first and foremost will add more API spec validations better protecting us from controller bugs. This is technically breaking changes, but since the trust-manager controller should be the only actor modifying Bundle status, I think it's fine.

Also removing the obsolete validation in the webhook for duplicate conditions. This was code is not needed after https://github.com/cert-manager/trust-manager/pull/173.

erikgb commented 8 months ago

/test pull-trust-manager-verify

SgtCoDFish commented 8 months ago

/lgtm /approve /unhold

Thanks!

jetstack-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [SgtCoDFish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment