Closed erikgb closed 8 months ago
/test pull-trust-manager-verify
/lgtm /approve /unhold
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: SgtCoDFish
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This is a PR that replaces https://github.com/cert-manager/trust-manager/pull/240. Since we decided to not migrate to the upstream
metav1.Condition
, I have tried to align our ownBundleCondition
as much as possible the the current upstream struct. Personally, I think it's an improvement that first and foremost will add more API spec validations better protecting us from controller bugs. This is technically breaking changes, but since the trust-manager controller should be the only actor modifyingBundle
status, I think it's fine.Also removing the obsolete validation in the webhook for duplicate conditions. This was code is not needed after https://github.com/cert-manager/trust-manager/pull/173.