cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
243 stars 65 forks source link

fix: apply-configuration gen for Bundle (cluster-scoped) #257

Closed erikgb closed 7 months ago

erikgb commented 8 months ago

While trying to migrate one of our operators to SSA, I realized a bug in https://github.com/cert-manager/trust-manager/pull/217. Bundle is a cluster-scoped resource, and needs an additional marker to generate a correct AC constructor. Please see https://kubernetes.slack.com/archives/C02MRBMN00Z/p1702911424438589 for details.

erikgb commented 7 months ago

/cc @inteon

jetstack-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment