Closed SgtCoDFish closed 7 months ago
@hawksight: adding LGTM is restricted to approvers and reviewers in OWNERS files.
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hawksight, inteon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
make image
is not as well defined asmake trust-package-debian-save
ormake trust-manager-load
, but it seems reasonable to have it available as a test when developing trust-manager.If
make image
also applies to the trust package, it requires that users come up with a value forDEBIAN_TRUST_PACKAGE_VERSION
which most users won't be able to guess.Most users should be using the provided commands for loading trust-manager into a kind cluster when developing, which sidesteps this problem entirely.
It feels like the simplest thing here is to have
make image
be an alias formake trust-manager-save
.