search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
243 stars 65 forks source link

Add an option to filter expired certificates from bundle #273

Closed Hoega closed 7 months ago

Hoega commented 7 months ago

Closes #272

Add an option to skip expired certificates and exclude them from the bundle.

The option is defined as a cli parameter to be passed by the helm charts values:

filterExpiredCertificates:
  # -- Whether to filter expired certificates from the trust bundle.
  enabled: false
erikgb commented 7 months ago

/ok-to-test

erikgb commented 7 months ago

/test pull-trust-manager-verify

erikgb commented 7 months ago

@Hoega Thanks a lot for this PR. I will try to review it soon!

Please run 'make -s update-helm-docs'

to fix the CI.

erikgb commented 7 months ago

/test pull-trust-manager-verify

jetstack-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [SgtCoDFish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment