Closed SgtCoDFish closed 7 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: erikgb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/unhold
Thanks for the review Erik 😁
This adds some checks on the new dummy expired certificate, and changes how we test filtering of expired certs.
I'd rather not check the exact output of
ValidateAndSanitizePEMBundleWithOptions
to check for cert expiry, since that'll be brittle if we change what that function outputs. This test instead explicitly checks for expired certs.