search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
243 stars 65 forks source link

Test tweaks following #273 #275

Closed SgtCoDFish closed 7 months ago

SgtCoDFish commented 7 months ago

This adds some checks on the new dummy expired certificate, and changes how we test filtering of expired certs.

I'd rather not check the exact output of ValidateAndSanitizePEMBundleWithOptions to check for cert expiry, since that'll be brittle if we change what that function outputs. This test instead explicitly checks for expired certs.

jetstack-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [erikgb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SgtCoDFish commented 7 months ago

/unhold

Thanks for the review Erik 😁