search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
233 stars 64 forks source link

No flag to set structured logging format, e.g. JSON? #282

Closed smec42 closed 1 month ago

smec42 commented 5 months ago

Describe the bug: In https://github.com/cert-manager/cert-manager/pull/5828 the option for setting the log-format to JSON was introduced to cert-manager. Is there a plan to enable this also for trust-manager? Structured logging can be enabled in the pod spec.

SgtCoDFish commented 5 months ago

This is definitely something we'd like - I'm personally very enthusiasic about programs having solid logging with JSON support. Definitely consider this on the "roadmap"!

My gut instinct is for us to aggressively change to using slog wherever possible, because I like using the stdlib where we can. But I'm not dogmatic about that.

No timeline for this currently, but I think this should be a thing we do!

arsenalzp commented 5 months ago

Hello, I can tackle this once decision is approved, if you wish.