search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
233 stars 64 forks source link

test: should test setBundleCondition as it's used #284

Closed erikgb closed 5 months ago

erikgb commented 5 months ago

While working on https://github.com/cert-manager/trust-manager/pull/239, I discovered that setBundleCondition is not tested as it's used after migration to SSA. To reduce the size of the other PR I am suggesting to fix this in a separate PR.

/cc @inteon

jetstack-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment