search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
233 stars 64 forks source link

Add optional resources block for init container #295

Closed niklastanner closed 4 months ago

niklastanner commented 5 months ago

Add optional resources block for the init container of the default package.

jetstack-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign erikgb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jetstack-bot commented 5 months ago

Hi @niklastanner. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
SgtCoDFish commented 4 months ago

/ok-to-test

SgtCoDFish commented 4 months ago

/test pull-trust-manager-verify

(pod was killed during the test I think)

SgtCoDFish commented 4 months ago

Hey @niklastanner thanks for raising this (and sorry it took a while to look into)! It looks like your PR is falling foul of the new values schema that was added. Are you able to also update the schema?

jetstack-bot commented 4 months ago

@niklastanner: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-trust-manager-verify 0106255da4ec76f706e5f276acf39ec1880ad660 link true /test pull-trust-manager-verify
pull-trust-manager-smoke 0106255da4ec76f706e5f276acf39ec1880ad660 link true /test pull-trust-manager-smoke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
niklastanner commented 4 months ago

@SgtCoDFish What do you mean by "update the schema"? It's the exact same schema already used by the main image. Building the template locally using helm template does generate a valid YAML file.

SgtCoDFish commented 4 months ago

My apologies - it looks like running make generate will solve the issue. I think the tests hiccuped when I looked - sorry!

SgtCoDFish commented 4 months ago

@niklastanner Are you able to run make generate locally quickly and commit the result? I might be able to squeeze this into the next trust-manager release this week if we're super quick

SgtCoDFish commented 4 months ago

@niklastanner I went ahead and did make generate in #316 just so we could include this in trust-manager v0.9.0

Thank you for your contribution, really appreciate you!