search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
229 stars 63 forks source link

Fix Bundle target print column #344

Closed erikgb closed 2 months ago

erikgb commented 2 months ago

It seems like the print columns were left behind when removing the copy of target under status in https://github.com/cert-manager/trust-manager/pull/230 and when introducing the opt-in for secrets as targets in https://github.com/cert-manager/trust-manager/pull/193.

I tried to figure out a better way to show either the configmap or the secret target key, but I don't know if JSONPath supports it. But a bundle could potentially specify both a configmap and secret as target, so two columns are probably best anyway.

Fixes https://github.com/cert-manager/trust-manager/issues/343

erikgb commented 2 months ago

/cc @inteon

inteon commented 2 months ago

Thanks for the PR, I tried to find a way to be smarter with the JSONPath, but I did not find any (please help if you are reading this and you are a JSONPath expert). /approve /lgtm

cert-manager-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment